[FIX] avoid concating # with url if there is no fragment.
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid adding `#` after url if there is no fragment.
Merged
|
Closing and reopening to trigger the CI tests again after merging #160. |
|
A new day, a new CI issue 😓 |
|
Incoming branch is 68 commits behind |
|
branch is updated. 👍 |
|
Thanks @EltonChou! |
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 7 7
Lines 478 478
Branches 93 93
=======================================
Hits 459 459
Misses 9 9
Partials 10 10
|
|
flake8 failure should be addressed here: #182 @EltonChou would you mind runing black on your changes, to fix the remaining CI failure? |
|
Actually, let me handle the failure. Thanks @EltonChou! Also, thanks @joe733 for the ping :) |
Merged
|
Merged as #183. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#72 will always concate
#with url.This PR add statement of checking fragment existence.